Skip to content

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 4, 2022

Fixes #130

Description

After moving to clap 4.0 it became possible to add a demo mode flag which will run Parseable with default credential and storage configuration.

Demo flag is exclusive and cannot be used with other configuration options.
A warning is printed when running with --demo flag

Changes

  • unify s3 config to main config as sub argument
  • add demo flag
  • default arguments only in demo mode

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Parseable is demo mode by default. After moving to clap 4.0 it became possible
to add a demo mode flag which will run Parseable with default credential and
storage configuration.

Demo flag is exclusive and cannot be used with other configuration options.
A warning is printed when one is running with `--demo` flag

changes
- unify s3 config to main config as sub argument
- add demo flag
- default arguments only in demo mode
@nitisht nitisht self-requested a review October 4, 2022 09:39
@nitisht nitisht merged commit 9c0862d into parseablehq:main Oct 4, 2022
@trueleo trueleo deleted the merge_option branch October 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a demo flag for server

2 participants