Skip to content

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Apr 7, 2023

Fixes #70 .

Description

  • Replace aws_sdk_s3 client with object_store::aws client

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht merged commit 8ccc2ee into parseablehq:main Apr 8, 2023
@trueleo trueleo deleted the object_store branch April 10, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify and use a single S3 client

2 participants