Refactor events #37
Merged
Refactor events #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueleo
commented
Aug 15, 2022
| string_schema: String, | ||
| storage: &impl ObjectStorage, | ||
| ) -> Result<response::EventResponse, Error> { | ||
| let mut c = Cursor::new(Vec::new()); |
There was a problem hiding this comment.
Underlying memory for this Cursor is a newly allocated Vec. Reader is then written in this vec but there is no usage of c beyond these 3 line. Is this dead code ?
|
We'll test this and then take it for first release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors some of the event processing code to remove duplicates and some of potentially dead code.
This PR has: