Use custom table provider to reuse statistics. #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theteachr
reviewed
Dec 9, 2023
Comment on lines
153
to
155
| if manifest_files.is_empty() { | ||
| return Ok(None); | ||
| } |
There was a problem hiding this comment.
We can return early, I think. If we move this to 130.
There was a problem hiding this comment.
There are calls to retain and truncate after 130. I think it is better to perform this check after all mutations to list have happened
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Make Table provider implementation directly create physical plan from manifest file entries. File level statistics are aggregated into table level statistics which is available for count optimization.
Note: Aggregate Statistics will only take effect for time range which lie exactly on minute boundary. Otherwise they are treated as partial filters and plan changes, hence will not use statistics anymore.
This PR has: