Skip to content

Conversation

AdheipSingh
Copy link
Contributor

@AdheipSingh AdheipSingh commented Aug 24, 2022

Description

  • Commenting the S3 env configs, as they get deployed as empty strings, and server takes those into consideration
  • Default should be commented off.
  • Added RUST_LOG to get logs for server
  • update Dockerfile rust version
  • Added security context

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@AdheipSingh AdheipSingh requested a review from nitisht August 24, 2022 14:48
@AdheipSingh AdheipSingh requested a review from nitisht August 24, 2022 16:20
@nitisht nitisht merged commit 2cf070c into parseablehq:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants