Skip to content

Match table statistics with table schema #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2023
Merged

Match table statistics with table schema #571

merged 2 commits into from
Dec 15, 2023

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Dec 14, 2023

Fixes #XXXX.

Description

Make Column Statistics line up with table schema as internally this is accessed via indexing

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested a review from theteachr December 14, 2023 09:01
theteachr
theteachr reviewed Dec 14, 2023
View reviewed changes
@nitisht nitisht requested a review from theteachr December 14, 2023 15:11
@nitisht nitisht merged commit f289529 into parseablehq:main Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
@trueleo trueleo deleted the fix-table-stats branch December 15, 2023 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@theteachr theteachr theteachr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueleo @theteachr @nitisht