Skip to content

fix for panic caused due to empty arrow files #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix for panic caused due to empty arrow files #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions server/src/storage/staging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,19 @@ impl StorageDir {
let random_string =
rand::distributions::Alphanumeric.sample_string(&mut rand::thread_rng(), 15);
for arrow_file_path in arrow_files {
let key = Self::arrow_path_to_parquet(&arrow_file_path, random_string.clone());
grouped_arrow_file
.entry(key)
.or_default()
.push(arrow_file_path);
if arrow_file_path.metadata().unwrap().len() == 0 {
log::error!(
"Invalid arrow file detected, removing it: {:?}",
arrow_file_path
);
fs::remove_file(&arrow_file_path).unwrap();
} else {
let key = Self::arrow_path_to_parquet(&arrow_file_path, random_string.clone());
grouped_arrow_file
.entry(key)
.or_default()
.push(arrow_file_path);
}
}
grouped_arrow_file
}
Expand Down