Use existing schema when querying local data. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datafusion needs a valid schema to execute a query. If no associated schema found for registered table then datafusion tries to infer that schema. If there are no available listings from which schema can be derived then it fails and returns an error. This causes entire query to fail and return error response. This is fixed by giving it a proper schema to work with that is already part of metadata. There are however ways that this schema is might not be available ( maybe first event has happened yet), then we simply return doing no changes to RecordBatch. Changes to be committed: modified: server/src/query.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Datafusion needs a valid schema to execute a query. If no associated schema found for registered table then datafusion tries to infer that schema. If there are no available listings from which schema can be derived then it fails and returns an error.
This causes entire query to fail and return error response. This is fixed by giving it a proper schema to work with that is already part of metadata. There are however ways that this schema is might not be available maybe first event has happened yet), then we simply return doing no changes to RecordBatch.
Fixes parseablehq/console#14.
This PR has: