fix: remove user_id from API requests in Dashboards and Filters #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nikhilsinhaparseable
force-pushed
the
userid-from-header
branch
from
6c0e839 to
e315eaf
Compare
Fetch session key from HttpRequest
then fetch username from the session
updated all APIs, removed user_id from API requests
while saving the json, generate hash for user_id
Dashboard API changes:
GET /dashboards/{user_id} -> GET /dashboards
this fetches all dashboards for user fetched from HttpRequest
GET /dashboards/dashboard/{dashboard_id} -> GET /dashboards/{dashboard_id}
DELETE /dashboards/dashboard/{dashboard_id} -> DELETE /dashboards/{dashboard_id}
PUT /dashboards/dashboard/{dashboard_id} -> PUT /dashboards/{dashboard_id}
Filter API changes:
GET /filters/{user_id} -> GET /filters
this fetches all filters for user fetched from HttpRequest
GET /filters/filter/{filter_id} -> GET /filters/{filter_id}
DELETE /filters/filter/{filter_id} -> DELETE /filters/{filter_id}
PUT /filters/filter/{filter_id} -> PUT /filters/{filter_id}
nikhilsinhaparseable
force-pushed
the
userid-from-header
branch
from
e315eaf to
9cff858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch session key from HttpRequest
then fetch username from the session
updated all APIs, removed user_id from API requests while saving the json, generate hash for user_id
Dashboard API changes:
GET /dashboards/{user_id} -> GET /dashboards
this fetches all dashboards for user fetched from HttpRequest
GET /dashboards/dashboard/{dashboard_id} -> GET /dashboards/{dashboard_id} DELETE /dashboards/dashboard/{dashboard_id} -> DELETE /dashboards/{dashboard_id} PUT /dashboards/dashboard/{dashboard_id} -> PUT /dashboards/{dashboard_id}
Filter API changes:
GET /filters/{user_id} -> GET /filters
this fetches all filters for user fetched from HttpRequest
GET /filters/filter/{filter_id} -> GET /filters/{filter_id} DELETE /filters/filter/{filter_id} -> DELETE /filters/{filter_id} PUT /filters/filter/{filter_id} -> PUT /filters/{filter_id}