Skip to content

Conversation

parmesant
Copy link
Contributor

Introduces separate handlers for different Parseable server modes

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@parmesant parmesant force-pushed the handler_separation branch 3 times, most recently from 064d749 to ab2001b Compare September 30, 2024 11:33
@parmesant parmesant marked this pull request as ready for review October 1, 2024 09:59
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 5d7cd68 into parseablehq:main Oct 1, 2024
8 checks passed
parmesant added a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants