Skip to content

fixed redirect url validation and included support for custom err messsge #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2024
Merged

fixed redirect url validation and included support for custom err messsge #944

merged 2 commits into from
Sep 28, 2024

Conversation

balaji-jr
Copy link
Contributor

@balaji-jr balaji-jr commented Sep 26, 2024 •
edited
Loading

Fixes #942.

Description

This pr addresses:

  1. Removed HTTP scheme when validating redirect URL with hosted URL. (This affects deployments having tls termination at the lb).
  2. Added support for custom error messages for the HTTP response on the OIDC controller.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@balaji-jr balaji-jr self-assigned this Sep 26, 2024
@balaji-jr balaji-jr requested review from nikhilsinhaparseable and nitisht and removed request for nikhilsinhaparseable September 26, 2024 14:46
nikhilsinhaparseable
nikhilsinhaparseable approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit d11a087 into parseablehq:main Sep 28, 2024
8 checks passed
@dhenry123
Copy link

Nice job, 1.5.3 is running.

Thank you so much.

parmesant pushed a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
@balaji-jr @parmesant
fixed redirect url validation and included support for custom err mes…
f1c91e1 
…ssge (parseablehq#944)

also add support for custom err message

fixes parseablehq#942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

@nitisht nitisht Awaiting requested review from nitisht

Assignees

@balaji-jr balaji-jr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Login: 400 Bad request

4 participants

@balaji-jr @dhenry123 @nikhilsinhaparseable @nitisht