refactor: use middlewares to reject requests when shutting down #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
commented
Oct 25, 2024
| ### actix dependencies | ||
| actix-web-httpauth = "0.8" | ||
| actix-web = { version = "4.5.1", features = ["rustls-0_22"] } | ||
| actix-web = { version = "4.9.0", features = ["rustls-0_22"] } |
There was a problem hiding this comment.
previously from_fn was part of an experimental crate, now it is in main
nikhilsinhaparseable
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
The idea behind this PR is to not have multiple copies of the shutdown handler code and as a BREAKING CHANGE it WILL result in all requests to ingest/query/server to be rejected with HTTP 503 status when
SIGNAL_RECEIVEDis set to true.This PR has: