Taking theme config and applying classes desired. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Planning test this against PL Node 3.0 alpha, in addition to to 2.X |
|
Ugh. Rendering blocking JS 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic implementation of what's discussed in #91 and I'm very open to refactoring. However, this gets the job done, has no flash of unsettled content as it's render blocking JS that requires no dependencies (works in IE10+), and will be very easy for @bradfrost to alter config settings in PL's config and apply that to the classes he'd like wherever.
I tested and saw the light theme, but didn't see the other options - I might be missing some of your work on the branches I pulled down though.