Skip to content

fix: get external resource blocked #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 26, 2025
Merged

fix: get external resource blocked #12927

merged 14 commits into from
Jun 26, 2025

Conversation

@kendelljoseph
Copy link
Contributor

@kendelljoseph kendelljoseph commented Jun 24, 2025 •
edited
Loading

Fix

  • Use [Config].upload.skipSafeFetch to allow specific external urls
  • Use [Config].upload.pasteURL.allowList to allow specific external urls

Documentation: Uploading files from remote urls

Fixes: #12876
Mentioned: #7037, #12934
Source PR: #12622
Issue Trace:

  1. allowList Added

  2. allowList Removed

@kendelljoseph kendelljoseph requested a review from denolfe June 24, 2025 20:37
@kendelljoseph kendelljoseph marked this pull request as ready for review June 25, 2025 13:59
denolfe
denolfe requested changes Jun 25, 2025
View reviewed changes
Copy link
Member

@denolfe denolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things should be improved.

Also be sure to add Fixes # if this PR fixes any open issues. I see related ones are listed but just wanted to be sure.

Let's run through testing this against real S3 or R2 today.

denolfe
denolfe reviewed Jun 25, 2025
View reviewed changes
@kendelljoseph kendelljoseph self-assigned this Jun 25, 2025
@kendelljoseph kendelljoseph changed the title fix: allowlist on external urls fix: get external resource Jun 25, 2025
@kendelljoseph kendelljoseph changed the title fix: get external resource fix: get external resource blocked Jun 25, 2025
This was referenced Jun 25, 2025
Open
Closed
Merged
denolfe
denolfe reviewed Jun 26, 2025
View reviewed changes
@denolfe denolfe merged commit a7ad573 into main Jun 26, 2025
74 of 77 checks passed
@denolfe denolfe deleted the fix/url-filters branch June 26, 2025 19:24
@kendelljoseph kendelljoseph mentioned this pull request Jun 26, 2025
Merged
kendelljoseph added a commit that referenced this pull request Jun 26, 2025
@kendelljoseph
test: adds test for skipSafeFetch allowList (#12954)
7ebac63 
Adds missing test in PR: #12927
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

🚀 This is included in version v3.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denolfe denolfe denolfe requested changes

Assignees

@kendelljoseph kendelljoseph

Labels

created-by: Payload team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage-s3: Changing uploaded Media fails with "Blocked unsafe attempt" in v3.43.0

3 participants

@kendelljoseph @denolfe