fix(plugins): Ensure IPC data is correctly passed to renderer plugins #4048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,4 +1,5 @@ | |||
| import is from 'electron-is'; | |||
| import { IpcRendererEvent } from 'electron'; | |||
There was a problem hiding this comment.
'IpcRendererEvent' is defined but never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was preventing the SponsorBlock plugin from working (#4046)
The problem was in our custom IPC wrapper for renderer plugins. It was accidentally stripping out the event object from incoming messages, which caused the actual data (like the skip segments for SponsorBlock) to get mixed up.
I've adjusted the wrapper to make sure it passes along all the arguments correctly. This gets SponsorBlock working again and makes our plugin system a bit more reliable for the future.