Update prereqs and switch to alternate build method #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than including node_modules in the repository, build a single file containing everything needed using @vercel/ncc. The file can be rebuilt using npm run build.
haarg
force-pushed
the
haarg/update-and-build
branch
from
482aa31 to
e903942
Compare
atoomic
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the node_modules from the repo, instead using the ncc utility to package all of the needed prereqs into a single file. This means that updating prereqs only requires updating the package.json, package-lock.json, and the built script, rather than needing to manage all of the files in node_modules.
The single built file can be updated using the command
npm run build.Also updates the prereqs being used, which should fix the warnings about
:set-output.