Got rid of setting output variables to logging messages #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrianCArnold
commented
Jun 6, 2023
BrianCArnold
commented
- I think the intent was to output information to the console, not to emit logging data as undeclared output variables.
- Also, setOutput is being removed, so if it needs to save output information, it needs to switch to the new environment file data.
… cpanm script...? I think the intent was to output information to the console, since there is no declared output variables in the action.yml. Also, setOutput is being removed, so if it needs to save output information, it should use the new environment file data.
BrianCArnold
changed the title
Contributor
Author
|
Additionally, changed from console.log to core.info, which is the standard way to emit output data to the workflow steps output. |
atoomic
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.