Fix #406 - Fixing createStatement function's options #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.25% // Head: 97.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=========================================
Coverage 97.25% 97.25%
Complexity 2194 2194
=========================================
Files 68 68
Lines 5057 5057
=========================================
Hits 4918 4918
Misses 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iifawzi
commented
Jan 15, 2023
Signed-off-by: Fawzi Abdulfattah <[email protected]>
iifawzi
force-pushed
the
fix-create-statement-options
branch
from
83190fc to
0922644
Compare
Signed-off-by: Fawzi Abdulfattah <[email protected]>
Signed-off-by: Fawzi Abdulfattah <[email protected]>
williamdes
approved these changes
Jan 17, 2023
williamdes
added a commit
that referenced
this pull request
Jan 17, 2023
Pull-request: #411 Signed-off-by: William Desportes <[email protected]>
|
I think it is cleaner this way, it required no changes except contexts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #406
Signed-off-by: Fawzi Abdulfattah [email protected]