Add Translator::setLocale() method #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static function load() | ||
| { | ||
| if (! class_exists(Loader::class)) { |
There was a problem hiding this comment.
Why is the guard needed now?
There was a problem hiding this comment.
Just because this method is public. But it should be private. And calling it directly without Loader will cause an error.
Maybe throwing an exception is better. Or annotating it as internal method, or both.
The Translator::setLocale() takes precedence over $GLOBALS['lang']. This makes possible to deprecate the usage of the $GLOBALS['lang']. Signed-off-by: Maurício Meneghini Fauth <[email protected]>
MauricioFauth
force-pushed
the
translator-locale
branch
from
d34538c to
c1044be
Compare
williamdes
approved these changes
Nov 17, 2024
MauricioFauth
added a commit
that referenced
this pull request
Dec 8, 2024
[ci skip] Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Translator::setLocale() takes precedence over $GLOBALS['lang']. This makes possible to deprecate the usage of the $GLOBALS['lang'].