Skip to content

Conversation

@rohanshah18
Copy link
Contributor

Problem

Some customers have requested to allow : in the source tag field and for all internal pinecone integration tests, add source tag as pinecone_test.

Solution

Allow : as a part of source tag and set pinecone_test as a source tag for integration test

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Updated unit test and ran integration tests

@rohanshah18 rohanshah18 requested a review from ssmith-pc June 18, 2024 18:54
@rohanshah18 rohanshah18 marked this pull request as ready for review June 18, 2024 18:54
@rohanshah18 rohanshah18 merged commit f7b850e into main Jun 20, 2024
@rohanshah18 rohanshah18 deleted the rshah/updateSourceTag branch June 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants