Skip to content

Conversation

@rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Jul 16, 2024

Problem

Add support for deletion protection.

Solution

Generated code using the following commands:

git submodule init && git submodule update
./codegen/build-oas.sh 2024-07

Next, as a part of this PR, I have:

  1. Added deletionProtection enum as an argument to createPodsIndex() and createServerlessIndex()
  2. Renamed configureIndex() to configurePodsIndex() and added deletionProtection enum as an argument.
  3. Added configureServerlessIndex() that accepts deletionProtection enum only.

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

Added integration tests

@rohanshah18 rohanshah18 changed the title Codegen for deletion protection Add support for deletion protection Jul 17, 2024
@rohanshah18 rohanshah18 marked this pull request as ready for review July 17, 2024 01:30
Copy link
Contributor

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into my feedback on the configure action, I think this is pretty important to avoid surprising people by accidentally turning it off.

Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Jen's feedback. Nice job getting this out the door.

@rohanshah18 rohanshah18 merged commit 2ce9ac5 into release-candidate/2024-07 Jul 17, 2024
@rohanshah18 rohanshah18 deleted the rshah/deletionProtection branch July 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants