Skip to content

Conversation

@nianliuu
Copy link
Contributor

@nianliuu nianliuu commented Oct 14, 2024

Problem

in pinecone, the default namespace is "", the check in list will throw exception if namespace is ""

Solution

remove the empty namespace check, only check namespace is null

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

./gradlew build, passed all tests

@nianliuu
Copy link
Contributor Author

@russcam can anyone help have a look of this PR? thank you!

@rohanshah18
Copy link
Contributor

@nianliuu thank you for creating the PR, I have ran the integration test. Once successful, I'll approve the PR.

@nianliuu
Copy link
Contributor Author

nianliuu commented Oct 24, 2024

The API key is required and must not be empty or null, looks like API-Key not set for IT @rohanshah18

Copy link
Contributor

@rohanshah18 rohanshah18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully run the integration tests with these changes, LGTM! Once again, thank you for creating the PR.

@rohanshah18 rohanshah18 merged commit f41e4b8 into pinecone-io:main Oct 29, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants