Update the datatype for parameters in rerank() #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
requested review from
aulorbe,
austin-denoble,
gdj0nes and
jhamon
ssmith-pc
approved these changes
Oct 23, 2024
rohanshah18
merged commit e2d0996
into
rshah/release-candidate/2024-10
6 of 7 checks passed
rohanshah18
added a commit
that referenced
this pull request
Oct 24, 2024
## Problem
Update the datatype of `parameters` in `rerank()` from `Map<String,
Object>` to `Map<String, String>` to better match the OAS.
## Solution
Updated the datatype for the rerank() so the base overloaded method is
now:
```java
public RerankResult rerank(String model,
String query,
List<Map<String, String>> documents,
List<String> rankFields,
int topN,
boolean returnDocuments,
Map<String, String> parameters)
```
As a part of this change, I have also updated the integration test and
README.
## Type of Change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)
## Test Plan
Updated the integration test for rerank and the rest of them should run
as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update the datatype of
parametersinrerank()fromMap<String, Object>toMap<String, String>to better match the OAS.Solution
Updated the datatype for the rerank() so the base overloaded method is now:
As a part of this change, I have also updated the integration test and README.
Type of Change
Test Plan
Updated the integration test for rerank and the rest of them should run as it is.