Update README based on regenerated code #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
commented
Oct 23, 2024
rohanshah18
requested review from
aulorbe,
austin-denoble,
gdj0nes,
jhamon and
ssmith-pc
rohanshah18
commented
Oct 23, 2024
gdj0nes
approved these changes
Oct 23, 2024
rohanshah18
added a commit
that referenced
this pull request
Oct 24, 2024
## Problem Regenerating the code based on new OAS caused changes in imports, so the examples in the README needs to be updated accordingly. ## Solution Changes include: 1. Updating import statements since inference is now broken out of control, so the paths for the openAPI generated model classes like `ApiException`, `IndexModel`, etc. were updated. 2. Import statement was missing for an example or two ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [X] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan No code changes so integration tests should run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regenerating the code based on new OAS caused changes in imports, so the examples in the README needs to be updated accordingly.
Solution
Changes include:
ApiException,IndexModel, etc. were updated.Type of Change
Test Plan
No code changes so integration tests should run successfully.