Update http client and improve error handling #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
commented
Sep 19, 2023
rohanshah18
commented
Sep 19, 2023
rohanshah18
commented
Sep 19, 2023
rohanshah18
commented
Sep 19, 2023
jhamon
approved these changes
Sep 20, 2023
Contributor
jhamon
left a comment
jhamon
left a comment
There was a problem hiding this comment.
In general I like the direction, OkHttpClient seems quite nice. But I do think we need some more iteration on this before merging (see comments below). I'm going to mark this as "Approve" so you can not be blocked while we're out of town if you make the requested changes and feel confident merging. But if you want another round of reviews, let us know.
rohanshah18
changed the title
jhamon
reviewed
Sep 22, 2023
jhamon
reviewed
Sep 22, 2023
jhamon
approved these changes
Sep 22, 2023
Contributor
jhamon
left a comment
jhamon
left a comment
There was a problem hiding this comment.
I left a few more suggestions, but overall it's looking great. Nice work.
austin-denoble
approved these changes
Sep 22, 2023
Contributor
austin-denoble
left a comment
austin-denoble
left a comment
There was a problem hiding this comment.
Great work here swapping out AsyncHttpClient for OkHttpClient. Really appreciate your attention to detail and improving our error handling. 🎉
src/main/java/io/pinecone/exceptions/PineconeAlreadyIndexExistsException.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The java sdk currently relies on AsyncHttpClient but keeping the long term goal in mind, will like to replace it with OkHttpClient. Also the errors raised are not clear enough for the users.
Solution
Replaced OkHttpClient for create and delete index functionalities. Also added httpErrorMapper which will provide details on why the exception occurred rather than throwing a high level IOException.
Type of Change
This is neither a bug fix nor a new feature but knowing that in future we'll like to rely on OkHttpClient, it is best to replace it now before implementing rest of the control plane operations.
Test Plan
Added unit tests and ran integration locally to make sure the client works as it used to before and is backwards compatible.