Update gRPC version to 1.58.0 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Sep 27, 2023
Contributor
austin-denoble
left a comment
austin-denoble
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Rohan! 🚢
Contributor
Author
|
Fixes issue#22 |
rohanshah18
added a commit
that referenced
this pull request
Sep 28, 2023
This reverts commit dcd85fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Java SDK currently uses gRPC version
1.53.0, which has a deprecated method calledattachHeaders. Since the latest release of gRPC version1.58.0, theattachHeadersmethod has been removed. Therefore, users running gRPC version1.58.0and attempting to use this SDK will encounter an error stating that the method is not found.Solution
Update gRPC version
1.53.0to the latest version1.58.0.Type of Change
Test Plan
Ran integration tests locally for all data plane operations.