Update protobuf to 5.29.5 to address security vulnerability #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Pinecone Python client is currently using protobuf version
^5.29
, which includes vulnerable versions that are affected by GHSA-8qvm-5x2c-j2w7. This vulnerability involves uncontrolled recursion in Protobuf's pure-Python backend, which could lead to Denial of Service (DoS) attacks.Solution
Updated the protobuf dependency constraint from
^5.29
to^5.29.5
to ensure we're using the patched version that addresses this security vulnerability. The changes include:pyproject.toml
: Changed protobuf version constraint from^5.29
to^5.29.5
testing-dependency-grpc.yaml
: Updated protobuf version from5.29.1
to5.29.5
in all three dependency testing matrix configurationspoetry.lock
already contains protobuf 5.29.5, so no additional lock file updates were neededThis is a patch version update, so no breaking changes are expected. The protobuf dependency is optional and only installed when the
grpc
extra is requested.Note: This is a security patch release to address the immediate vulnerability for existing users. A future release will include a comprehensive update to protobuf 6.x, which may include breaking changes and will require more extensive testing and migration planning.
Type of Change
Test Plan