[pingcap/tidb#46609] support s3 profile for dumpling #21456
Conversation
ti-chi-bot
bot
added
do-not-merge/work-in-progress
|
Hi @takaidohigasi. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
the
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @takaidohigasi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a documentation update for TiDB's data export utility, Dumpling. It clarifies and expands on the methods available for authenticating with AWS S3, specifically noting the newly introduced support for S3 profiles. This enhancement ensures that users have comprehensive information regarding credential handling when exporting data to S3.
Highlights
- Documentation Update: The
dumpling-overview.mddocumentation has been updated to reflect that Dumpling, the data export tool, now supports using S3 profiles for credential management. This is in addition to its existing support for reading credentials from~/.aws/credentials.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/XS
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
|
Implementation was merged, and I'm happy if you can remove |
|
this change was merged and maybe released with 8.5.3, but document is not merged and there isn't release note for it. |
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
Don't worry, the PR is not cherry-picked to v8.5.3 /cc @qiancai PTAL |
|
@lance6716: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
removed
the
missing-translation-status
Co-authored-by: Grace Cai <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…b.com/takaidohigasi/docs into 46609-support-s3-profile-for-dumpling
ti-chi-bot
bot
added
size/S
…ials Update the example to explicitly mention that default credentials are read from ~/.aws/credentials 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
thanks for the review |
| To use a specific AWS profile: | ||
|
|
||
| ```shell | ||
| tiup dumpling -u root -P 4000 -h 127.0.0.1 -r 200000 -o "s3://${Bucket}/${Folder}" --s3.profile=my.profile |
There was a problem hiding this comment.
In the code PR pingcap/tidb#62199 the format should be
... -o "s3://${Bucket}/${Folder}/?profile=my_profile"
Can you double check --s3.profile will also work?
There was a problem hiding this comment.
yes it was noted merged PR description
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
qiancai
added
translation/done
3 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
add s3 profile support document for dumpling
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
br: support s3 profile config tidb#62199