Adding support for trickle ice. #88
Open
+132
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipi87
force-pushed
the
filipi/trickle_ice
branch
from
249f014 to
6e6d2fa
Compare
filipi87
commented
Oct 15, 2025
| transport: new SmallWebRTCTransport({ | ||
| waitForICEGathering: true, | ||
| }), | ||
| transport: new SmallWebRTCTransport(), |
There was a problem hiding this comment.
TODO: need to update to use the latest version of @pipecat-ai/small-webrtc-transport and pipecat-ai in order for it to work.
kompfner
reviewed
Oct 16, 2025
| if (event.candidate) { | ||
| console.log("New ICE candidate:", event.candidate); | ||
| // Check if we can send ICE candidates (we have received the answer with pc_id) | ||
| if (pc.canSendIceCandidates && pc.pc_id) { |
There was a problem hiding this comment.
Why do we need to check for both pc.canSendIceCandidates && pc.pc_id? pc.canSendIceCandidates looks like it already encompasses the latter condition.
There was a problem hiding this comment.
Yeah, just an extra precaution, but it shouldn’t be necessary.
kompfner
reviewed
Oct 16, 2025
| ) | ||
| ] | ||
| # Initialize the SmallWebRTC request handler | ||
| small_webrtc_handler: SmallWebRTCRequestHandler = SmallWebRTCRequestHandler() |
There was a problem hiding this comment.
This file is much cleaner using the nice encapsulation you've built into SmallWebRTCRequestHandler!
kompfner
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.