Upgrade from OJS 3.4.0-8 to OJS 3.5.0rc2

[shantanu198713]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

PHP-8.3.14
MYSQL-9.1

I attempted to upgrade from OJS 3.4.0-8 to OJS 3.5.0rc2, but the process failed due to the following error. The upgrade could not be completed successfully, and troubleshooting is required to identify and resolve the issue.

Steps to Reproduce

I attempted to upgrade from OJS 3.4.0-8 to OJS 3.5.0rc2.

Expected Result

Continue to upgrade.

Actual Result

Upgradation failed.

Environment Details

No response

Application Version

OJS-3.5.0rc2

Logs

PHP Fatal error:  Uncaught TypeError: PKP\invitation\core\Invitation::initialize(): Argument #2 ($contextId) must be of type ?int, string given, called in H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\migration\upgrade\v3_5_0\I9197_MigrateAccessKeys.php on line 92 and defined in H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\invitation\core\Invitation.php:112
Stack trace:
#0 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\migration\upgrade\v3_5_0\I9197_MigrateAccessKeys.php(92): PKP\invitation\core\Invitation->initialize(45, 'MailListContext', NULL, NULL)
#1 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(444): PKP\migration\upgrade\v3_5_0\I9197_MigrateAccessKeys->up()
#2 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(297): PKP\install\Installer->executeAction(Array)
#3 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(206): PKP\install\Installer->executeInstaller()
#4 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\form\UpgradeForm.php(49): PKP\install\Installer->execute()
#5 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\pages\install\InstallHandler.php(148): PKP\install\form\UpgradeForm->execute()
#6 [internal function]: PKP\pages\install\InstallHandler->installUpgrade(Array, Object(APP\core\Request))
#7 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\core\PKPRouter.php(327): call_user_func(Array, Array, Object(APP\core\Request))
#8 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\core\PKPPageRouter.php(249): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(APP\core\Request), Array, false)
#9 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\core\Dispatcher.php(157): PKP\core\PKPPageRouter->route(Object(APP\core\Request))
#10 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\core\PKPApplication.php(422): PKP\core\Dispatcher->dispatch(Object(APP\core\Request))
#11 H:\wamp64\www\ojs-3.5.0rc2\index.php(21): PKP\core\PKPApplication->execute()
#12 {main}
  thrown in H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\invitation\core\Invitation.php on line 112

Additional Information

---

PRs

🗂 Branch: stable-3_5_0
──────────────────────────────
✅ pkp-lib: #11210 (MERGED)
🧪 OJS: pkp/ojs#4795 (TESTS ONLY)

✅ pkp-lib: #11217 (MERGED)
🧪 OJS: pkp/ojs#4805 (TESTS ONLY)

✅ pkp-lib: #11234
🧪 OJS: pkp/ojs#4816 (TESTS ONLY)

🗂 Branch: main
──────────────────────────────
✅ pkp-lib: #11211 (MERGED)
🧪 OJS: pkp/ojs#4796 (TESTS ONLY)

✅ pkp-lib: #11218 (MERGED)

✅ pkp-lib: #11235
🧪 OJS: pkp/ojs#4817 (TESTS ONLY)

[shantanu198713]

Hi @kaitlinnewson kindly guide me for above error so that I can continue further Upgradation test.

[kaitlinnewson]

Hi @defstat, are you able to take a look at this one? It looks to be an issue with a migration related to the invitations work (#9197).

[defstat]

Sure @kaitlinnewson!

@shantanu198713 Thanks for reporting this. From the logs you posted, it looks like the access_key that's causing the upgrade issue is of type 'MailListContext'. Do you know which feature in your installation might be generating this type of access key? Also, could you check if it’s already expired? It might be coming from a plugin you're using or possibly leftover data from a previous migration?

In any case, I’ve added a proposed solution in the description comment of this issue. You're welcome to try it out on your installation if you'd like.

@asmecher Do you have some time to review it?

[asmecher]

Thanks, @defstat, I've merged both of those PRs. The MailListContext value for the context column comes from very old versions of OJS 2.x, and can be ignored (and even discarded).

[shantanu198713]

Hi @defstat @asmecher @kaitlinnewson

Thank you for your response.

I have applied the patches mentioned above, and the access_key error has been resolved. However, I am now encountering a new error during the upgrade process, which is mentioned below.

Could you please guide me on resolving this error and proceeding with further upgrade testing?

Error Log

2025-04-01 09:27:13 [downgrade for "PKP\migration\upgrade\v3_5_0\I9771_OrcidMigration" unsupported: Downgrade not supported]
ERROR: Upgrade failed: DB: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`ojs`.`publications`, CONSTRAINT `publications_issue_id_foreign` FOREIGN KEY (`issue_id`) REFERENCES `issues` (`issue_id`) ON DELETE SET NULL) in H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php:571
Stack trace:
#0 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(571): PDOStatement->execute()
#1 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(812): Illuminate\Database\Connection->Illuminate\Database\{closure}('\n              ...', Array)
#2 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(779): Illuminate\Database\Connection->runQueryCallback('\n              ...', Array, Object(Closure))
#3 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(560): Illuminate\Database\Connection->run('\n              ...', Array, Object(Closure))
#4 H:\wamp64\www\ojs-3.5.0rc2\classes\migration\upgrade\v3_5_0\I10157_CreateAndMigrateIssueIdField.php(48): Illuminate\Database\Connection->statement('\n              ...')
#5 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(444): APP\migration\upgrade\v3_5_0\I10157_CreateAndMigrateIssueIdField->up()
#6 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(297): PKP\install\Installer->executeAction(Array)
#7 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(206): PKP\install\Installer->executeInstaller()
#8 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\cliTool\UpgradeTool.php(97): PKP\install\Installer->execute()
#9 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\cliTool\UpgradeTool.php(70): PKP\cliTool\UpgradeTool->upgrade()
#10 H:\wamp64\www\ojs-3.5.0rc2\tools\upgrade.php(22): PKP\cliTool\UpgradeTool->execute()
#11 {main}

Next Illuminate\Database\QueryException: SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (`ojs`.`publications`, CONSTRAINT `publications_issue_id_foreign` FOREIGN KEY (`issue_id`) REFERENCES `issues` (`issue_id`) ON DELETE SET NULL) (Connection: mysql, SQL:
                    UPDATE publications p
                    JOIN publication_settings ps
                        ON p.publication_id = ps.publication_id
                        AND ps.setting_name = 'issueId'
                    SET p.issue_id = ps.setting_value
                ) in H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php:825
Stack trace:
#0 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(779): Illuminate\Database\Connection->runQueryCallback('\n              ...', Array, Object(Closure))
#1 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\lib\vendor\laravel\framework\src\Illuminate\Database\Connection.php(560): Illuminate\Database\Connection->run('\n              ...', Array, Object(Closure))
#2 H:\wamp64\www\ojs-3.5.0rc2\classes\migration\upgrade\v3_5_0\I10157_CreateAndMigrateIssueIdField.php(48): Illuminate\Database\Connection->statement('\n              ...')
#3 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(444): APP\migration\upgrade\v3_5_0\I10157_CreateAndMigrateIssueIdField->up()
#4 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(297): PKP\install\Installer->executeAction(Array)
#5 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\install\Installer.php(206): PKP\install\Installer->executeInstaller()
#6 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\cliTool\UpgradeTool.php(97): PKP\install\Installer->execute()
#7 H:\wamp64\www\ojs-3.5.0rc2\lib\pkp\classes\cliTool\UpgradeTool.php(70): PKP\cliTool\UpgradeTool->upgrade()
#8 H:\wamp64\www\ojs-3.5.0rc2\tools\upgrade.php(22): PKP\cliTool\UpgradeTool->execute()
#9 {main}

Database Structure Screenshot for reference

Publications Table

Issues Table

[shantanu198713]

I checked the access_keys table and found 96 rows with an expiry_date set to 2038, where the context is set to MailListContext. Given this, is it safe to manually delete these rows from the table?