Draft: Feature 587 turmoil http.1 client-server test #642

Babbleshack · 2025-07-25T18:19:48Z

Adds a simple http.1 client - server test using tokio-turmoil

Addresses #587

- Adds `test-turmoil/test-client-server` package - Adds simple client server test using tokio-turmoil

Babbleshack · 2025-07-25T18:21:11Z

@GlenDC or @soundofspace I was wondering if I could get some early feedback here.

Am interested to know if this is what you guys had in mind?

What do you think of the package structure?

Any changes you would like to see?

GlenDC

Looks fine to me. Left some feedback already.
Besides that, two questions:

Why does this need to be a separate package? Can this not be just another main application in /tests?
What is the output when you run this? Is it just binary it works or fails? are there warnings. Asking as I haven't played with turmoil myself yet.

GlenDC · 2025-07-25T18:55:14Z

Cargo.toml

@@ -48,7 +48,7 @@ members = [
    "rama-udp",
    "rama-unix",
    "rama-utils",
-    "rama-ws",
+    "rama-ws", "tests-turmoil/test-client-server",


give entries their own line please

tests-turmoil/test-client-server/Cargo.toml

GlenDC · 2025-07-25T18:55:59Z

tests-turmoil/test-client-server/Cargo.toml

+
+[dependencies]
+rama = { path = "../..", features = ["full"] }
+turmoil = "0.6"


add as a workspace dep first and than use { workspace = true }

GlenDC · 2025-07-25T18:56:15Z

tests-turmoil/test-client-server/Cargo.toml

+tokio = { workspace = true }
+serde = { workspace = true }
+serde_json = { workspace = true }
+tracing = { workspace = true }


use from rama-core

GlenDC · 2025-07-25T18:56:34Z

tests-turmoil/test-client-server/src/main.rs

+};
+use turmoil::Builder;
+
+const ADDRESS: SocketAddress = SocketAddress::default_ipv4(62004);


you made sure this port is not used by any other test?

GlenDC · 2025-07-25T18:57:00Z

tests-turmoil/test-client-server/src/main.rs

+    HttpServer::http1()
+        .listen(
+            address.into(),
+            (TraceLayer::new_for_http()).into_layer(WebService::default().get("/", "Hello, World")),


useless round brackets

tests-turmoil/test-client-server/src/main.rs

GlenDC · 2025-07-25T18:58:31Z

tests-turmoil/test-client-server/src/main.rs

+            (TraceLayer::new_for_http()).into_layer(WebService::default().get("/", "Hello, World")),
+        )
+        .await
+        .map_err(|e| e as Box<dyn std::error::Error>)


Suggested change

.map_err(|e| e as Box<dyn std::error::Error>)

.map_err(Into::into)

This wont work, but also here we are trying to coerce the type so that w ecan drop the Send + Sync trait bounds.

Co-authored-by: Glen De Cauwsemaecker <[email protected]>

Babbleshack · 2025-07-25T19:33:14Z

Looks fine to me. Left some feedback already. Besides that, two questions:

1. Why does this need to be a separate package? Can this not be just another main application in `/tests`?

2. What is the output when you run this? Is it just binary it works or fails? are there warnings. Asking as I haven't played with turmoil myself yet.

I think I mis-interpretted your instructions from the ticket (Add distributed session/application layer tests using turmoil #587).

I would keep these tests separate from other tests and just add them under ./tests-turmoil/, each test its own cargo project there. This way we can add them to the workspace via the pattern ./tests-turmoil/* in our cargo toml of the rama workspace.

Now I have re-read this I think what you actually wanted was integration tests in a /tests/turmoil package. Ill make this change.

2. What is the output when you run this? Is it just binary it works or fails? are there warnings. Asking as I haven't played with turmoil myself yet.

There are no outputs unless logging is enabled.

If the assertion fails, the binary panics as expected.

If a Result::Err is returned from one of the async closure than it is returned similar to JoinHandle behaviour.

For example if we do:

    let mut sim = Builder::new().enable_tokio_io().build();
    sim.host(ADDRESS.ip_addr(), || async {
       Err("error returned from server".into())
    });
    
    sim.client(...);
    
    sim.run().expect("Error during simulation");

$ cargo run
...
2025-07-25T19:30:18.246122Z  INFO turmoil: New nodename="0.0.0.0" addr=0.0.0.0
2025-07-25T19:30:18.247514Z  INFO turmoil: New nodename="client" addr=192.168.0.1

thread 'main' panicked at tests-turmoil/test-client-server/src/main.rs:73:23:
Error during simulation: "error returned from server"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

GlenDC · 2025-07-25T20:03:58Z

Is there no bookkeeping that can be checked to see what inputs and parameters it used during the tests? And how to know it ran at all?

Babbleshack · 2025-07-25T21:08:58Z

Is there no bookkeeping that can be checked to see what inputs and parameters it used during the tests? And how to know it ran at all?

There are some functions for inspecting the simulation state:

The simulation (struct Sim) provide some functions for manipulating the environment.

However after some more investigation I dont believe this test is using the turmoil net types.

$ RUST_LOG=INFO,turmoil=TRACE cargo test --test turmoil --features http-full
    Finished `test` profile [optimized] target(s) in 0.30s
     Running tests/turmoil/main.rs (target/debug/deps/turmoil-e998ab69135e2f65)

running 1 test
2025-07-25T21:02:52.748036Z  INFO turmoil: New nodename="0.0.0.0" addr=0.0.0.0
2025-07-25T21:02:52.748150Z  INFO turmoil: New nodename="client" addr=192.168.0.1
2025-07-25T21:02:52.748167Z TRACE turmoil: step 1
2025-07-25T21:02:52.748389Z TRACE turmoil: step 2
2025-07-25T21:02:52.748559Z TRACE turmoil: step 3
2025-07-25T21:02:52.748604Z TRACE turmoil: step 4
test http::http_1_client_server_it ... ok

The output should show network traffice as it sent and delivered.

I think I need to adjust the client and server so that they are using turmoil::net types.

Something more like:

2023-11-29T20:23:43.277039Z TRACE node{name="client"}: turmoil: Delivered src=192.168.0.1:9999 dst=192.168.0.2:49152 protocol=TCP [...]
2023-11-29T20:23:43.277097Z TRACE node{name="client"}: turmoil: Recv src=192.168.0.1:9999 dst=192.168.0.2:49152 protocol=TCP [..]
2023-11-29T20:23:43.277324Z  INFO client: axum_example: Got response: Response { status: 200, version: HTTP/1.1, headers: {"content-type": "text/plain; charset=utf-8", "content-length": "10", "date": "Wed, 29 Nov 2023 20:23:43 GMT"}, body: b"Hello foo!" }
...

We could use something like tracing_test to scrape logs and assert specific network events.

Although its not great. I think a better solution might be to add counters to the turmoil::Sim type

GlenDC · 2025-07-26T11:34:15Z

Cool I think what you have of tracing and output is probably good enough for now, unless you think differently.

Dominic Lindsay added 4 commits July 20, 2025 23:07

add turmoil project directory

0029870

Skeleton

0c74e15

Initial http-client-server turmoil test

be43333

- Adds `test-turmoil/test-client-server` package - Adds simple client server test using tokio-turmoil

Merge branch 'main' into feature-587-turmoil-client-server

e3ecc8d

Dominic Lindsay added 2 commits July 25, 2025 19:22

add clippy lints

7510fd8

fmt

753e2b0

GlenDC requested changes Jul 25, 2025

View reviewed changes

Babbleshack and others added 4 commits July 25, 2025 20:23

Update tests-turmoil/test-client-server/src/main.rs

b1dae2f

Co-authored-by: Glen De Cauwsemaecker <[email protected]>

Update tests-turmoil/test-client-server/src/main.rs

e6b41cc

Co-authored-by: Glen De Cauwsemaecker <[email protected]>

Update tests-turmoil/test-client-server/Cargo.toml

d6f74b0

Co-authored-by: Glen De Cauwsemaecker <[email protected]>

Update tests-turmoil/test-client-server/src/main.rs

c017bbb

Co-authored-by: Glen De Cauwsemaecker <[email protected]>

reomve brackets

c57148b

Dominic Lindsay added 2 commits July 25, 2025 21:48

Move testing code around

6c57dc7

fmt

0d4a824

broken bits

03184f8

GlenDC force-pushed the main branch 3 times, most recently from 153e3e8 to 049503f Compare July 28, 2025 00:21

Dominic Lindsay added 3 commits July 30, 2025 12:32

Initial http client trait bounds

5f7d8bb

TurmoilTcpConnector draft

807895f

Merge branch 'main' into feature-587-turmoil-client-server

8b4f6ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Draft: Feature 587 turmoil http.1 client-server test #642

Draft: Feature 587 turmoil http.1 client-server test #642

Babbleshack commented Jul 25, 2025 •

edited

Loading

Uh oh!

Babbleshack commented Jul 25, 2025

Uh oh!

GlenDC left a comment

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

GlenDC Jul 25, 2025

Uh oh!

Babbleshack Jul 25, 2025

Uh oh!

Babbleshack commented Jul 25, 2025

Uh oh!

GlenDC commented Jul 25, 2025

Uh oh!

Babbleshack commented Jul 25, 2025 •

edited

Loading

Uh oh!

GlenDC commented Jul 26, 2025

Uh oh!

Uh oh!

	.map_err(\|e\| e as Box<dyn std::error::Error>)
	.map_err(Into::into)

Uh oh!

Draft: Feature 587 turmoil http.1 client-server test #642

Are you sure you want to change the base?

Draft: Feature 587 turmoil http.1 client-server test #642

Conversation

Babbleshack commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Babbleshack commented Jul 25, 2025

Uh oh!

GlenDC left a comment

Choose a reason for hiding this comment

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GlenDC Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Babbleshack Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Babbleshack commented Jul 25, 2025

Uh oh!

GlenDC commented Jul 25, 2025

Uh oh!

Babbleshack commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GlenDC commented Jul 26, 2025

Uh oh!

Uh oh!

Babbleshack commented Jul 25, 2025 •

edited

Loading

Babbleshack commented Jul 25, 2025 •

edited

Loading