fix quickstart-428 #429
Merged
fix quickstart-428 #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindawoo-plaid
approved these changes
Jun 20, 2023
SpencerHHurst
pushed a commit
to SpencerHHurst/quickstart
that referenced
this pull request
Jul 10, 2024
fix quickstart-428
fisherrjd
pushed a commit
to fisherrjd/quickstart
that referenced
this pull request
Oct 12, 2024
fix quickstart-428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #428 wherein the frontend will not start using node 18 (it works fine with node 16).
This fix is based on a suggestion I found here:
facebook/create-react-app#12304
You'd think that removing this line would break things! But it didn't. I mean, at least not for me.
Another approach I found that also fixed it was to export the environment variable
DANGEROUSLY_DISABLE_HOST_CHECK=trueas part of the start script, but the optics of that seemed a little bad.