Add support for passing socket info through to SERVER superglobal #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added optional support for passing through local and remote socket information to the
$_SERVER
superglobal.Note that this is also designed to line up with the names on
req.socket
so you can pass that in as the socket info object too.I've also improved the safety of the
Request
andResponse
constructors a bit, making it throw proper JS errors rather than usingunwrap()
orexpect()
which would kill the process on invalid inputs.Also,
argv
is now required as it always should have been. 😅