Skip to content

Conversation

@jowlo
Copy link
Contributor

@jowlo jowlo commented Jun 1, 2023

Multiple dcc.Location were replacing the others event handlers for 'popstate'. If any dcc.Location was unmounted, there was no event handler left

fix #1312

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)

optionals

  • I have added entry in the CHANGELOG.md

@jowlo jowlo requested a review from alexcjohnson as a code owner June 1, 2023 10:49
Multiple dcc.Location were replacing the others event handlers for
'popstate'. If any dcc.Location was unmounted, there was no event
handler left

fix plotly#1312
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💃

@T4rk1n T4rk1n merged commit 8894c45 into plotly:dev Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] No callback to dcc.Location when two or more dcc.Location are placed in layout

2 participants