Skip to content

Histogram events & bin hover label improvements #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 24, 2017
Merged

Histogram events & bin hover label improvements #2113

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
59b6463
let timeit work with n=1
alexcjohnson Oct 18, 2017
6dc9904
give Lib.findBin a tiny buffer for on-the-line points
alexcjohnson Oct 19, 2017
ccf1a76
update histograms to include input point numbers in events and smart …
alexcjohnson Oct 19, 2017
1b356d2
lint histogram2d calc
alexcjohnson Oct 20, 2017
8f8add1
:palm_tree: histogram2d calc
alexcjohnson Oct 20, 2017
7686096
refactor bar/hist hover
alexcjohnson Oct 20, 2017
8d36d81
factor out bin_label_vals so histogram2d can use it too
alexcjohnson Oct 20, 2017
a7e2f32
extend event data and bin label improvements to histogram2d
alexcjohnson Oct 20, 2017
6b74fbe
:hocho: TODOs we've done
alexcjohnson Oct 20, 2017
b91d1cb
exclude CDFs from new histogram event & label features
alexcjohnson Oct 20, 2017
ad0e08f
limit the number of extra digits we give to histogram bin labels
alexcjohnson Oct 23, 2017
6cb4e71
test bin_label_vals
alexcjohnson Oct 23, 2017
7581567
use unicode minus in `Axes.hoverLabelText`
alexcjohnson Oct 23, 2017
51ad8c2
get rid of (x|y)LabelVal(0|1), in favor of (x|y)Label
alexcjohnson Oct 23, 2017
3aa03f7
tests of histogram hover label range format, and log-negative format
alexcjohnson Oct 23, 2017
cc454dc
TODO -> comment
alexcjohnson Oct 24, 2017
2696c1c
test event data for histogram
alexcjohnson Oct 24, 2017
0331a16
test case for category range histogram hover labels
alexcjohnson Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devtools/test_dashboard/perf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ window.timeit = function(f, n, nchunk, arg) {
times.sort();
var min = (times[0]).toFixed(4);
var max = (times[n - 1]).toFixed(4);
var median = (times[Math.ceil(n / 2)]).toFixed(4);
var median = (times[Math.min(Math.ceil(n / 2), n - 1)]).toFixed(4);
var mean = (totalTime / n).toFixed(4);
console.log((f.name || 'function') + ' timing (ms) - min: ' + min +
' max: ' + max +
Expand Down
22 changes: 14 additions & 8 deletions src/lib/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
var isNumeric = require('fast-isnumeric');
var loggers = require('./loggers');

// don't trust floating point equality - fraction of bin size to call
// "on the line" and ensure that they go the right way specified by
// linelow
var roundingError = 1e-9;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised that this hadn't come up before (other than the test below that was actually wrong before), and obviously it's a bit questionable exactly what small fraction to put here... but if we just use straight < vs <= etc it's pretty easy to trick findBin on the edges.



/**
* findBin - find the bin for val - note that it can return outside the
Expand All @@ -26,20 +31,21 @@ var loggers = require('./loggers');
exports.findBin = function(val, bins, linelow) {
if(isNumeric(bins.start)) {
return linelow ?
Math.ceil((val - bins.start) / bins.size) - 1 :
Math.floor((val - bins.start) / bins.size);
Math.ceil((val - bins.start) / bins.size - roundingError) - 1 :
Math.floor((val - bins.start) / bins.size + roundingError);
}
else {
var n1 = 0,
n2 = bins.length,
c = 0,
n,
test;
if(bins[bins.length - 1] >= bins[0]) {
var n1 = 0;
var n2 = bins.length;
var c = 0;
var binSize = (n2 > 1) ? (bins[n2 - 1] - bins[0]) / (n2 - 1) : 1;
var n, test;
if(binSize >= 0) {
test = linelow ? lessThan : lessOrEqual;
} else {
test = linelow ? greaterOrEqual : greaterThan;
}
val += binSize * roundingError * (linelow ? -1 : 1) * (binSize >= 0 ? 1 : -1);
// c is just to avoid infinite loops if there's an error
while(n1 < n2 && c++ < 100) {
n = Math.floor((n1 + n2) / 2);
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/histogram_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ describe('Test histogram', function() {
var trace4 = {x: [1, 1.2, 1.4, 1.6], yaxis: 'y2'};

expect(calcPositions(trace1, [trace2, trace3, trace4])).toEqual([1, 2, 3, 4]);
expect(calcPositions(trace3)).toBeCloseToArray([0.9, 1.1, 1.3], 5);
expect(calcPositions(trace3)).toBeCloseToArray([1.1, 1.3], 5);
});

describe('cumulative distribution functions', function() {
Expand Down