Skip to content

Configurable select direction #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 17, 2018
Merged

Configurable select direction #2506

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6d820f7
Add "selectdirection" layout attribute
GlennMatthys Mar 29, 2018
9595cbe
Implement support for selectdirection layout attribute in cartesian s…
GlennMatthys Mar 29, 2018
5cfc474
Image mocks for selectdirection
GlennMatthys Mar 29, 2018
b782c88
Remove redundant default
GlennMatthys Mar 30, 2018
2112759
Remove unnecessary test cases
GlennMatthys Mar 30, 2018
c49d829
Add initial test case
GlennMatthys Apr 5, 2018
69c3157
Add tests for h, v and d select directions & cleanup
GlennMatthys Apr 6, 2018
d65ffc8
Merge branch 'master' into configurable-select-direction
alexcjohnson Apr 17, 2018
6d4a4f8
edit selectdirection test
alexcjohnson Apr 17, 2018
9dd166c
selectdirection PR review edits
alexcjohnson Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/fx/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,17 @@ module.exports = {
].join(' ')
},
editType: 'none'
},
selectdirection: {
valType: 'enumerated',
role: 'info',
values: ['h', 'v', 'd', 'any'],
dflt: 'any',
description: [
'When "dragmode" is set to "select", this limits the selection of the drag to',
'horizontal, vertical or diagonal. "h" only allows horizontal selection,',
'"v" only vertical, "d" only diagonal and "any" sets no limit.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like 'd', I guess what it allows that 'any' doesn't is selecting regions that are very narrow in height or width, which would otherwise devolve to pure horizontal or vertical selections. Cool.

].join(' '),
editType: 'none'
}
};
1 change: 1 addition & 0 deletions src/components/fx/layout_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module.exports = function supplyLayoutDefaults(layoutIn, layoutOut, fullData) {
}

coerce('dragmode');
coerce('selectdirection', 'any');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the attribute has dflt: 'any' already, you do not need to include it here.


var hovermodeDflt;
if(layoutOut._has('cartesian')) {
Expand Down