Display bar outlines with height zero #3848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
May 9, 2019
etpinard
reviewed
May 9, 2019
|
TODO: we need to display |
|
@archmoj reading up #3797 (comment) again, in particular:
we should add a hover test, locking down the behaviour. |
done in 7224fe4 💃 from me. Feel free to merge this thing! |
|
@etpinard thanks very much for the help on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3797 i.e. for bars as well as histograms.
Note: a similar fix was not desirable for waterfalls/funnels.
And the text is not printed when the bar height is zero.
@plotly/plotly_js