Refactor parcoords - bug fixes - reuse axes ticktext - support pseudo html labels - features for label angle & position

src/traces/parcoords/attributes.js

@@ -17,38 +17,49 @@ var extendFlat = require('../../lib/extend').extendFlat;
 var templatedArray = require('../../plot_api/plot_template').templatedArray;
 
 module.exports = {
-    domain: domainAttrs({name: 'parcoords', trace: true, editType: 'calc'}),
+    domain: domainAttrs({name: 'parcoords', trace: true, editType: 'plot'}),
+
+    labelangle: {
+        valType: 'angle',
+        dflt: 0,
+        role: 'style',
+        editType: 'plot',
+        description: [
+            'Sets the angle of the labels with respect to the horizontal.',
+            'For example, a `tickangle` of -90 draws the labels vertically.'
+        ].join(' ')
+    },
 
     labelfont: fontAttrs({
-        editType: 'calc',
+        editType: 'plot',
         description: 'Sets the font for the `dimension` labels.'
     }),
     tickfont: fontAttrs({
-        editType: 'calc',
+        editType: 'plot',
         description: 'Sets the font for the `dimension` tick values.'
     }),
     rangefont: fontAttrs({
-        editType: 'calc',
+        editType: 'plot',
         description: 'Sets the font for the `dimension` range values.'
     }),
 
     dimensions: templatedArray('dimension', {
         label: {
             valType: 'string',
             role: 'info',
-            editType: 'calc',
+            editType: 'plot',
             description: 'The shown name of the dimension.'
         },
         // TODO: better way to determine ordinal vs continuous axes,
         // so users can use tickvals/ticktext with a continuous axis.
         tickvals: extendFlat({}, axesAttrs.tickvals, {
-            editType: 'calc',
+            editType: 'plot',
             description: [
                 'Sets the values at which ticks on this axis appear.'
             ].join(' ')
         }),
         ticktext: extendFlat({}, axesAttrs.ticktext, {
-            editType: 'calc',
+            editType: 'plot',
             description: [
                 'Sets the text displayed at the ticks position via `tickvals`.'
             ].join(' ')
@@ -57,7 +68,7 @@ module.exports = {
             valType: 'string',
             dflt: '3s',
             role: 'style',
-            editType: 'calc',
+            editType: 'plot',
             description: [
                 'Sets the tick label formatting rule using d3 formatting mini-language',
                 'which is similar to those of Python. See',
@@ -68,17 +79,17 @@ module.exports = {
             valType: 'boolean',
             dflt: true,
             role: 'info',
-            editType: 'calc',
+            editType: 'plot',
             description: 'Shows the dimension when set to `true` (the default). Hides the dimension for `false`.'
         },
         range: {
             valType: 'info_array',
             role: 'info',
             items: [
-                {valType: 'number', editType: 'calc'},
-                {valType: 'number', editType: 'calc'}
+                {valType: 'number', editType: 'plot'},
+                {valType: 'number', editType: 'plot'}
             ],
-            editType: 'calc',
+            editType: 'plot',
             description: [
                 'The domain range that represents the full, shown axis extent. Defaults to the `values` extent.',
                 'Must be an array of `[fromValue, toValue]` with finite numbers as elements.'
@@ -90,10 +101,10 @@ module.exports = {
             freeLength: true,
             dimensions: '1-2',
             items: [
-                {valType: 'number', editType: 'calc'},
-                {valType: 'number', editType: 'calc'}
+                {valType: 'number', editType: 'plot'},
+                {valType: 'number', editType: 'plot'}
             ],
-            editType: 'calc',
+            editType: 'plot',
             description: [
                 'The domain range to which the filter on the dimension is constrained. Must be an array',
                 'of `[fromValue, toValue]` with `fromValue <= toValue`, or if `multiselect` is not',
@@ -104,7 +115,7 @@ module.exports = {
             valType: 'boolean',
             dflt: true,
             role: 'info',
-            editType: 'calc',
+            editType: 'plot',
             description: 'Do we allow multiple selection ranges or just a single range?'
         },
         values: {

src/traces/parcoords/axisbrush.js

@@ -419,7 +419,7 @@ function getBrushExtent(brush) {
 
 function brushClear(brush) {
     brush.filterSpecified = false;
-    brush.svgBrush.extent = [[0, 1]];
+    brush.svgBrush.extent = [[-Infinity, Infinity]];
 }
 
 function axisBrushMoved(callback) {
@@ -458,6 +458,14 @@ function makeFilter() {
             filter = a
                 .map(function(d) { return d.slice().sort(sortAsc); })
                 .sort(startAsc);
+
+            // handle unselected case
+            if(filter.length === 1 &&
+                filter[0][0] === -Infinity &&
+                filter[0][1] === Infinity) {
+                filter = [[0, -1]];
+            }
+
             consolidated = dedupeRealRanges(filter);
             bounds = filter.reduce(function(p, n) {
                 return [Math.min(p[0], n[0]), Math.max(p[1], n[1])];

src/traces/parcoords/base_plot.js

@@ -13,18 +13,16 @@ var getModuleCalcData = require('../../plots/get_data').getModuleCalcData;
 var parcoordsPlot = require('./plot');
 var xmlnsNamespaces = require('../../constants/xmlns_namespaces');
 
-var PARCOORDS = 'parcoords';
-
-exports.name = PARCOORDS;
+exports.name = 'parcoords';
 
 exports.plot = function(gd) {
-    var calcData = getModuleCalcData(gd.calcdata, PARCOORDS)[0];
+    var calcData = getModuleCalcData(gd.calcdata, 'parcoords')[0];
     if(calcData.length) parcoordsPlot(gd, calcData);
 };
 
 exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout) {
-    var hadParcoords = (oldFullLayout._has && oldFullLayout._has(PARCOORDS));
-    var hasParcoords = (newFullLayout._has && newFullLayout._has(PARCOORDS));
+    var hadParcoords = (oldFullLayout._has && oldFullLayout._has('parcoords'));
+    var hasParcoords = (newFullLayout._has && newFullLayout._has('parcoords'));
 
     if(hadParcoords && !hasParcoords) {
         oldFullLayout._paperdiv.selectAll('.parcoords').remove();

src/traces/parcoords/calc.js

@@ -21,7 +21,7 @@ module.exports = function calc(gd, trace) {
     var lineColor;
     var cscale;
 
-    if(Colorscale.hasColorscale(trace, 'line') && Array.isArray(trace.line.color)) {
+    if(Colorscale.hasColorscale(trace, 'line') && Array.isArray(trace.line.color)) { // TODO: should we support typed arrays here?
         lineColor = trace.line.color;
         cscale = Colorscale.extractOpts(trace.line).colorscale;
 

src/traces/parcoords/defaults.js

@@ -100,4 +100,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     Lib.coerceFont(coerce, 'labelfont', fontDflt);
     Lib.coerceFont(coerce, 'tickfont', fontDflt);
     Lib.coerceFont(coerce, 'rangefont', fontDflt);
+
+    coerce('labelangle');
 };