Skip to content

introduce spikesnap mode "hovered data" #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

introduce spikesnap mode "hovered data" #4665

merged 1 commit into from
Mar 19, 2020

Conversation

antoinerg
Copy link
Contributor

Fixes #4657

This PR introduces a spikesnap mode called hovered data which ensures that a spike line is not drawn if there are no hover points.

@antoinerg antoinerg added this to the v1.53.0 milestone Mar 19, 2020
@antoinerg antoinerg added the feature something new label Mar 19, 2020
@antoinerg antoinerg requested a review from alexcjohnson March 19, 2020 21:16
alexcjohnson
alexcjohnson approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Love it.

@antoinerg antoinerg merged commit 6de4c75 into master Mar 19, 2020
@antoinerg antoinerg deleted the spike-hover-congruence branch March 19, 2020 21:32
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

feature something new

Projects

None yet

Milestone

v1.53.0

Development

Successfully merging this pull request may close these issues.

spike/hover congruence

2 participants

@antoinerg @alexcjohnson