Skip to content

Update title and tick labels during react with transition #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Update title and tick labels during react with transition #5045

merged 1 commit into from
Aug 11, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 4, 2020

Fixes #5037 and fixes #5044.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Aug 4, 2020
alexcjohnson
alexcjohnson approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Elegant fix, precisely-targeted test. Love it! 💃

@archmoj archmoj merged commit e27fd71 into master Aug 11, 2020
@archmoj archmoj deleted the fix-5037-react-transition-titles branch August 11, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

bug something broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Category order not updating when using react with transition layout.transition.duration prevents layout.title.text changes

2 participants

@archmoj @alexcjohnson