Revise second condition in is_plain_object #5411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - I locally tested #5151 (comment) and it works with the proposed change. |
alexcjohnson
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Excellent. Looks like we already have good unit tests for this in https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/is_plain_object_test.js. I can't think of an easy way to add a cross-context test, for the precise problem discussed in #5151 so I guess this is all we need! 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5151 thanks to @alexcjohnson's second suggestion in #5151 (comment).
cc: #5395
@plotly/plotly_js