Skip to content

Avoid duplicate keys in plotly builds #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021
+7 −243
Merged

Avoid duplicate keys in plotly builds #5458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d83c50e
bump colormap by reinstalling gl-cone3d gl-mesh3d and gl-surface3d
archmoj Feb 2, 2021
734c61a
add a test to lock issues similar to 5457
archmoj Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ jobs:
- run:
name: Test plotly bundles againt unexpected characters
command: npm run no-bad-char
- run:
name: Test plotly bundles againt duplicate keys
command: npm run no-dup-keys
- run:
name: Test certain bundles against function constructors
command: npm run no-new-func
Expand Down
246 changes: 3 additions & 243 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"lint-fix": "eslint . --fix || true",
"no-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: error}' $(find dist -type f -iname '*.js' | grep -v plotly-gl* | grep -v plotly-with-meta.* | grep -v plotly.js | grep -v plotly.min.js | grep -v MathJax.js)",
"no-bad-char": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-misleading-character-class: error}' $(find dist -type f -iname '*.js' | grep plotly)",
"no-dup-keys": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-dupe-keys: error}' $(find dist -type f -iname '*.js' | grep plotly)",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we run this test on everything there are failures at:

plotly.js/dist/extras/mathjax/config/TeX-AMS-MML_SVG.js
  44:35070  error  Duplicate key '.'           
  49:6575   error  Duplicate key 'rowspacing'  

plotly.js/dist/extras/mathjax/extensions/TeX/AMSmath.js
  19:6575  error  Duplicate key 'rowspacing'  

plotly.js/dist/extras/mathjax/jax/element/mml/jax.js
  19:35070  error  Duplicate key '.'

"docker": "node tasks/docker.js",
"pretest": "node tasks/pretest.js",
"test-jasmine": "karma start test/jasmine/karma.conf.js",
Expand Down