Adding the ability to specify the tail of an annotation arrow in abso…#610

Merged

etpinard merged 20 commits intoplotly:masterfrom

mdfederici:absolutetail

Jun 20, 2016

Commits on Jun 3, 2016

Adding the ability to specify the tail of an annotation arrow in absolute point in grid terms rather than relative pixel offset terms.

MFed
authored and
MFed
committed

Commits on Jun 5, 2016

Adding the ability to specify the tail of an annotation arrow in absolute point in grid terms rather than relative pixel offset terms. This is useful for the specification of trendlines which will …

MFed
authored and
MFed
committed
Merge remote-tracking branch 'origin/trendline' into trendline

MFed
authored and
MFed
committed

Commits on Jun 7, 2016

Fixing text and editing.

MFed
authored and
MFed
committed
code review feedback

MFed
authored and
MFed
committed
Adding the ability to specify the tail of an annotation arrow in absolute point in grid terms rather than relative pixel offset terms. Squashing commits

MFed
authored and
MFed
committed
Adding the ability to specify the tail of an annotation arrow in absolute point in grid terms rather than relative pixel offset terms.

MFed
authored and
MFed
committed
Merge remote-tracking branch 'origin/trendline' into trendline

MFed
authored and
MFed
committed
Trying to fix tests for absolutetail.

MFed
authored and
MFed
committed
Removing these unit tests because they are of dubious value relative to the time I'm spending trying to figure out why they are breaking everything else.

MFed
authored and
MFed
committed
fixing the unit tests for annotations and adding them back.

MFed
authored and
MFed
committed
fixing timezone problem in annotations test.

MFed
authored and
MFed
committed
fixing lint for annotation tests.

MFed
authored and
MFed
committed

Commits on Jun 14, 2016

Switching absolutetail to axref, ayref based on code review feedback. Can't figure out how the regex for axis ref works, so hardcoded to x,y for now and seeking guidance.

MFed
authored and
MFed
committed
Merge remote-tracking branch 'upstream/master' into trendline

MFed
authored and
MFed
committed
Merge remote-tracking branch 'origin/absolutetail' into absolutetail

MFed
authored and
MFed
committed
somehow I lost this change in my screw up with the branches.

MFed
authored and
MFed
committed
Not hardcoding axis references but using regex and coerce. Purposeful duplication of code per github PR 610

MFed
authored and
MFed
committed

Commits on Jun 16, 2016

Fixing bug where annotation would be marked as offscreen if the head was offscreen even if the tail is in coordinate space and on screen.

MFed
authored and
MFed
committed

Commits on Jun 20, 2016

Fixing a bug where the x,y of the arrow would be changed to stay on the chart, rather than render off screen when panned. Added corresponding annotation to image test.

MFed
authored and
MFed
committed