- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.9k
 
          Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features
          #6909
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 104 commits
      Commits
    
    
            Show all changes
          
          
            112 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      24876d8
              
                esbuild first cut
              
              
                alexcjohnson 8d6d9ee
              
                put output name back to plotly.js
              
              
                alexcjohnson fd7e445
              
                update package-lock diff
              
              
                archmoj 59af538
              
                uninstall webpack
              
              
                archmoj 9481fe5
              
                uninstall webpack-cli
              
              
                archmoj b70ad83
              
                uninstall node-polyfill-webpack-plugin
              
              
                archmoj ab7abd5
              
                uninstall karma-webpack
              
              
                archmoj 63d3de8
              
                drop webpack from devtools/test_dashboard/server.mjs
              
              
                archmoj 55c03d8
              
                remove webpack.config.js
              
              
                archmoj 2b8d93a
              
                install buffer
              
              
                archmoj cf5633e
              
                install assert
              
              
                archmoj ca525fd
              
                rename devtools/regl_codegen/server from js to mjs
              
              
                archmoj 390b0f1
              
                remove unused purgeGeneratedCode function
              
              
                archmoj 2a04743
              
                replace esbuild with webpack in devtools/regl_codegen/server
              
              
                archmoj 0d6fd10
              
                rename tasks/bundle.js to tasks/bundle.mjs
              
              
                archmoj abc4532
              
                es6 imports in tasks/bundle.mjs
              
              
                archmoj 687276a
              
                bundle_wrapper.js > bundle_wrapper.mjs
              
              
                archmoj 5701b7e
              
                rename cibundle.js & partial_bundle.js to .mjs
              
              
                archmoj 34f564e
              
                es6 import _bundle function
              
              
                archmoj 80f0547
              
                replace webpack with esbuild in bundle_wrapper
              
              
                archmoj ea7b866
              
                use esbuild to make bundles
              
              
                archmoj ad00767
              
                rewrite custom_bundle and extra_bundles in es6
              
              
                archmoj c2c21d9
              
                js > mjs
              
              
                archmoj 1ebbfad
              
                adjust export in partial_bundle.mjs
              
              
                archmoj a6d1437
              
                do not provide sourcemap for now
              
              
                archmoj bf75f64
              
                fix bundle_wrapper
              
              
                archmoj 1ccaec5
              
                skip no-new-func test for now
              
              
                archmoj 867ba0d
              
                delete node12 tests
              
              
                archmoj e2b52c6
              
                set minimum node16 in package.json
              
              
                archmoj d529e2a
              
                update package-lock for node 16 minimum
              
              
                archmoj 885438f
              
                install esbuild-plugin-browserify-adapter
              
              
                archmoj 32aa650
              
                compress attributes
              
              
                archmoj 6825cd3
              
                add noCompress true to geo assets
              
              
                archmoj 785c131
              
                tasks/schema.js -> tasks/schema.mjs
              
              
                archmoj 80763d9
              
                use es6 in tasks/schema.mjs
              
              
                archmoj 6916369
              
                tasks/util/plotly_node.js > tasks/util/plotly_node.mjs
              
              
                archmoj d14cd90
              
                use es6 in tasks/util/plotly_node.mjs
              
              
                archmoj 9762041
              
                use es6 in tasks/test_plain_obj.js
              
              
                archmoj ae00d3c
              
                tasks/test_plain_obj.js > tasks/test_plain_obj.mjs
              
              
                archmoj f0baa3e
              
                tasks/test_requirejs.js > tasks/test_requirejs.mjs
              
              
                archmoj 7177040
              
                use es6 in tasks/test_requirejs.mjs
              
              
                archmoj 6488c80
              
                use plotly_node.mjs in tasks/schema.mjs
              
              
                archmoj b8468cc
              
                use es6 in tasks/test_mock.js
              
              
                archmoj 39fd544
              
                tasks/test_mock.js > tasks/test_mock.mjs
              
              
                archmoj c75eeb5
              
                fix bundle to generate both minified & unmininified
              
              
                archmoj 523359a
              
                fix bundle_wrapper to not clear plugins
              
              
                archmoj 0c935b1
              
                install esbuild-plugin-babel
              
              
                archmoj e96dc01
              
                use esbuild-plugin-babel in esbuild-config
              
              
                archmoj b8fc583
              
                fx-config
              
              
                archmoj f400d1c
              
                no plugins to bundle geo assests
              
              
                archmoj cd0c603
              
                improve name of _bundle option
              
              
                archmoj 5ba702d
              
                fix empty plugins
              
              
                archmoj 4b50e9a
              
                fix esbuild config setup
              
              
                archmoj 05b3940
              
                adjust esbuild config
              
              
                archmoj 4bf46a2
              
                skip requirejs and amdefine tests for now
              
              
                archmoj faaff88
              
                drop babel step
              
              
                archmoj 70f6ef0
              
                fix disabling attribute meta compression
              
              
                archmoj 7e69158
              
                fix __dirname in test_mock
              
              
                archmoj 8498c54
              
                install karma-esbuild
              
              
                archmoj 13c9a5e
              
                use esbuild with karma and jasmine
              
              
                archmoj 7ab0faf
              
                drop babel
              
              
                archmoj dc0dcbe
              
                drop amdefine test
              
              
                archmoj 204a20d
              
                simplify minified_bundle case
              
              
                archmoj 6004bd5
              
                clear IE option in karma config
              
              
                archmoj 1aa9dba
              
                fx
              
              
                archmoj 4e49206
              
                reduce parallelism for jasmine tests
              
              
                archmoj 0d3d915
              
                Merge branch 'master' into build-with-esbuild
              
              
                archmoj d74aee5
              
                bring back amdefine test
              
              
                archmoj 0561f4c
              
                drop babel deps
              
              
                archmoj 5795d71
              
                install esbuild-plugin-umd-wrapper
              
              
                archmoj e83406b
              
                add umd wrapper
              
              
                archmoj c699c40
              
                revise adjusting plugins
              
              
                archmoj 3903e1e
              
                fix bundle wrapper
              
              
                archmoj 01db669
              
                fix second bundles
              
              
                archmoj 96a5e7e
              
                revise bundles
              
              
                archmoj 1c10191
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj 8ec3eaf
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj 776c0ac
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj bbbfb4a
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj e10ab24
              
                inline d3.round in drawing/symbol_defs.js
              
              
                archmoj 003383f
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj 81d103d
              
                update package-lock
              
              
                archmoj 8ba1116
              
                convert map/styles/arcgis from json to js - fix esbuild
              
              
                archmoj 5d326d8
              
                Merge branch 'master' into build-with-esbuild_dev
              
              
                archmoj 4909b42
              
                amdWrapper
              
              
                birkskyum 76fe186
              
                note meta
              
              
                birkskyum d1a806a
              
                Merge pull request #7122 from birkskyum/add-amdWrapper
              
              
                archmoj acff993
              
                add UMD wrapper in bundle_wrapper
              
              
                archmoj d7fd65c
              
                Revert "inline d3.round in drawing/symbol_defs.js"
              
              
                archmoj 935be96
              
                Revert "Revert "inline d3.round in drawing/symbol_defs.js""
              
              
                archmoj 9f0267b
              
                uninstall unused assert
              
              
                archmoj 8457dd5
              
                Revert "uninstall unused assert"
              
              
                archmoj a4778cd
              
                Use esbuild 23.1
              
              
                birkskyum c148acf
              
                fix lock
              
              
                birkskyum 38d6cd4
              
                draftlog
              
              
                birkskyum 0c724cf
              
                Merge pull request #7124 from birkskyum/esbuild-23
              
              
                archmoj 9e4d9d4
              
                fix regl_codegen
              
              
                birkskyum dca267a
              
                launch server after files are generated
              
              
                birkskyum ab8d688
              
                do not add Plotly to window in case of AMD
              
              
                archmoj e0faf1d
              
                Merge pull request #7125 from birkskyum/fix-regl-codegen
              
              
                archmoj 108b6f7
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj d0dd957
              
                fix import path in custom bundle script
              
              
                archmoj 46723a8
              
                adjust custom bundle script - fast creation of both minified and unmi…
              
              
                archmoj c2776aa
              
                correct node 18 version in package files
              
              
                archmoj 8bb92f8
              
                bring back unminified arg for custom bundles
              
              
                archmoj 04ce6ee
              
                draft log
              
              
                archmoj 48ed832
              
                revert changes to CUSTOM_BUNDLE.md
              
              
                archmoj b7189bd
              
                Add .css loader to esbuild
              
              
                birkskyum 6275c72
              
                trailing comma
              
              
                birkskyum 3328875
              
                Merge pull request #7142 from birkskyum/add-style-plugin
              
              
                archmoj 53f896c
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj 1b48536
              
                Merge remote-tracking branch 'origin/master' into build-with-esbuild
              
              
                archmoj File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              This file was deleted.
      
      Oops, something went wrong.
      
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.