Skip to content
This repository was archived by the owner on Jul 4, 2022. It is now read-only.

Conversation

@jordy25519
Copy link
Contributor

@jordy25519 jordy25519 commented Mar 4, 2020

Fixed history version of develop branch with latest upstream changes

Notable differences to upstream runtime:

  • Reverted: lazy reaping
  • Removed: indices module usage in the runtime to facilitate reverting the former
  • Excluded: lazy payouts
  • Removed: Kusama related migration tests and code

The main place to review would be the frame_system module and primitives/runtime/src/testing.rs changes around the TestXt type.

Most conflicts were dependency name updates, spelling fixes, and reversions of stuff mentioned above


This will become the new develop trunk it won't be merged

Copy link
Contributor

@hoani hoani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no issues found in frame_system or primitives/runtime/src/testing.rs

Copy link
Contributor

@cowboy-bebug cowboy-bebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The changes in frame_system and primitives/runtime/src/testing.rs were mostly refactors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants