Skip to content

Refactors commands to use listItem utils. Closes #5309 #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactors commands to use listItem utils. Closes #5309 #5359

wants to merge 1 commit into from

Conversation

@nicodecleyre
Copy link
Contributor

@nicodecleyre nicodecleyre commented Jul 28, 2023

Closes #5309

@Adam-it
Copy link
Member

Adam-it commented Jul 28, 2023

Thank @nicodecleyre for another PR 👍 We will review it ASAP 🕵️‍♂️
BTW please do remember to also take care of the already reviewed PRs left in draft awaiting your feedback 🙏

@plamber plamber self-requested a review August 6, 2023 15:36
@plamber plamber self-assigned this Aug 6, 2023
@Adam-it Adam-it assigned Adam-it and unassigned plamber Aug 20, 2023
@Adam-it
Copy link
Member

Adam-it commented Aug 20, 2023

@plamber I will be taking over this one to go over all refactor to util PRs

@nicodecleyre nicodecleyre force-pushed the Refactor-spo-tenant-commandset-add branch from 1370ec3 to c630ff9 Compare September 6, 2023 21:16
@Adam-it Adam-it marked this pull request as draft September 17, 2023 22:29
@Adam-it
Copy link
Member

Adam-it commented Sep 17, 2023

setting to draft due to the following observations
I will provide more guidance how we should proceed with this PR in near future

@martinlingstuyl martinlingstuyl force-pushed the Refactor-spo-tenant-commandset-add branch from c630ff9 to 20530eb Compare April 18, 2025 15:35
@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Apr 18, 2025

Rebased.... review commencing later

@martinlingstuyl martinlingstuyl marked this pull request as ready for review April 18, 2025 15:36
@martinlingstuyl martinlingstuyl marked this pull request as draft May 2, 2025 15:55
@martinlingstuyl martinlingstuyl force-pushed the Refactor-spo-tenant-commandset-add branch from 64d110b to 0e1f939 Compare May 3, 2025 20:15
@martinlingstuyl martinlingstuyl force-pushed the Refactor-spo-tenant-commandset-add branch from ab44007 to eb4d15e Compare May 9, 2025 21:03
@martinlingstuyl martinlingstuyl marked this pull request as ready for review May 9, 2025 21:05
@martinlingstuyl martinlingstuyl removed the request for review from plamber May 9, 2025 21:05
@martinlingstuyl martinlingstuyl changed the title Refactor spo tenant commandset add to use util instead of calling other command, Closes #5309 Refactors commands to use listItem utils. Closes #5309 May 9, 2025
This was referenced May 9, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@martinlingstuyl martinlingstuyl

@Adam-it Adam-it

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor commands to use listItem and appcatalog utils instead of calling other command

4 participants

@nicodecleyre @Adam-it @martinlingstuyl @plamber