Add Linux support to MPQ #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiuyqwert
reviewed
Sep 4, 2025
| ('StormLib.dll', ctypes.c_wchar_p), | ||
| ('StormLib64.dll', ctypes.c_wchar_p), | ||
| ('StormLib.dylib', ctypes.c_char_p), | ||
| ('StormLibLinux.so', ctypes.c_char_p), |
There was a problem hiding this comment.
Could you update the filename so it is just StormLib.so to keep consistency?
There was a problem hiding this comment.
Just in case I didn't comment where I should have, I answered in #150
Short answer:
I can't rename it StormLib.so as this seems to conflict (I'm guessing with the DLL) and I don't have the knowledge/experience to fix it.
|
Great, thank you very much for your contribution! I left one comment if you have time to make that change. |
Seems like I can't quite do that. I couldn't find/understand what is upsetting during the import of StormLib. I checked that it's correctly using CDLL instead of WinDLL, and the extension should be included, so I don't know. But as I renamed, it worked great. There must be some priority conflict with the DLL, but I'm stuck if this is a requirement, sorry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.