Remove deprecated Metadata getters #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
approved these changes
Aug 16, 2019
Contributor
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
nice! Yeah this simplifies the classes a lot
Member
Author
|
I've just started going through CodeClimate, all the F's and working my way downwards when I'm waiting for unrelated stuff to get in. Each one requires a bit of a re-think (for the better) in various areas. |
ianhe8x
pushed a commit
to plugblockchain/api.js
that referenced
this pull request
Aug 20, 2019
* Remove deprecated Metadata getters * Start metadata with som injected types * Cleanup V0 somewhat with injected types * Re-generate interfaces * Extract some Storage type definitions * Remove unneeded Calls & Constants files in metadata
ianhe8x
pushed a commit
to plugblockchain/api.js
that referenced
this pull request
Aug 20, 2019
* Remove deprecated Metadata getters * Start metadata with som injected types * Cleanup V0 somewhat with injected types * Re-generate interfaces * Extract some Storage type definitions * Remove unneeded Calls & Constants files in metadata
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally move some (low-hanging) type classes from Metadata to interface definitions