add iterator type to get_grouped_daily_aggs return #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
requested review from
danielatpolygonio and
mmoghaddam385
as code owners
|
Hi @tobealive ! Thanks for this PR! I think you are right that this should be Iterable, or maybe more concretely List. Can you include a screenshot of the type error and maybe a snippet that triggers it in the description of the PR? I'm wondering why our type checking and tests aren't catching this. |
|
hey @danielatpolygonio, thanks for covering this.
|
jbonzo
reviewed
Dec 8, 2022
Co-authored-by: Ricky Barillas <[email protected]>
jbonzo
approved these changes
Dec 9, 2022
|
@tobealive Thanks for the contribution! We appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into a type error that doesn't seem like it should be an error, I'm assuming this return type should be iterable. Like other similar returns give a collection of data.
the comments below describe it as
Listso something is most definitely off.:return: List of grouped daily aggregates