Skip to content

fix: ticker events returns composite_figi #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix: ticker events returns composite_figi #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
837a839
fix: ticker events returns composite_figi
Apr 12, 2023
3618d78
Merge branch 'master' into shooit/ticker-events-composite-figi
justinpolygon May 20, 2023
53843d4
Merge branch 'master' into shooit/ticker-events-composite-figi
justinpolygon Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polygon/rest/models/tickers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def from_dict(d):
@modelclass
class TickerChangeResults:
name: str
figi: str
composite_figi: str
cik: str
events: Optional[List[TickerChangeEvent]] = None

Expand Down
4 changes: 2 additions & 2 deletions test_rest/mocks/vX/reference/tickers/META/events&types=ticker_change.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"results": {
"name": "Meta Platforms, Inc. Class A Common Stock",
"figi": "BBG000MM2P62",
"composite_figi": "BBG000MM2P62",
"cik": "0001326801",
"events": [
{
Expand All @@ -22,4 +22,4 @@
},
"status": "OK",
"request_id": "8c911ff1-5ca8-41e8-9bbf-e625141caacc"
}
}
2 changes: 1 addition & 1 deletion test_rest/test_tickers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def test_get_ticker_events_ticker_change(self):
events = self.c.get_ticker_events(ticker="META", types="ticker_change")
expected = TickerChangeResults(
name="Meta Platforms, Inc. Class A Common Stock",
figi="BBG000MM2P62",
composite_figi="BBG000MM2P62",
cik="0001326801",
events=[
{
Expand Down